Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add phased rollout demo #14

Merged
merged 7 commits into from
Nov 14, 2024
Merged

feat: add phased rollout demo #14

merged 7 commits into from
Nov 14, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

Adds a demo project to the phased rollout guide. Current guide draft here

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 🧪 Tests
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman bryanoltman marked this pull request as draft November 13, 2024 20:20
felangel
felangel reviewed Nov 13, 2024
View reviewed changes
progressive_rollout_demo/pubspec.yaml Outdated
package_info_plus: ^8.1.1
shared_preferences: ^2.3.3
shorebird_code_push:
path: /Users/bryanoltman/shorebirdtech/engine/src/third_party/updater/shorebird_code_push
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to use the published version before merging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. We'll also need to update the readme to point to the actual guide.

@bryanoltman bryanoltman marked this pull request as ready for review November 14, 2024 20:16
eseidel
eseidel approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with the published version fix.

@bryanoltman bryanoltman merged commit e13d290 into main Nov 14, 2024
4 checks passed
@bryanoltman bryanoltman deleted the bo/progressive-rollouts branch November 14, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel left review comments

@eseidel eseidel eseidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanoltman @eseidel @felangel