Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: console.shorebird.dev insights tab reports times in UTC #1761

Open
eseidel opened this issue Feb 28, 2024 · 3 comments
Open

fix: console.shorebird.dev insights tab reports times in UTC #1761

eseidel opened this issue Feb 28, 2024 · 3 comments
Labels
bug Something isn't working console

Comments

@eseidel
Copy link
Contributor

eseidel commented Feb 28, 2024

This has come up for a couple users recently, where our reporting in UTC has been confusing to users closely monitoring their patch installs:
#1753 (comment)

@eseidel eseidel added the bug Something isn't working label Feb 28, 2024
@bryanoltman bryanoltman changed the title fix: console.shorebird.dev reports times in UTC fix: console.shorebird.dev insights tab reports times in UTC Mar 20, 2024
@bryanoltman
Copy link
Contributor

This will require changes to how the code push server communicates insights information to the console. Currently, it returns a list of

typedef PatchInstallMetadata = ({
  int patchNumber,
  int installCount,
  DateTime date,
});

Where these are grouped by day on the server side without knowing the client's time zone.

@bryanoltman
Copy link
Contributor

Otherwise, dates on the console seem to be reported correctly in local time

Screenshot 2024-03-20 at 11 31 56 AM

@eseidel
Copy link
Contributor Author

eseidel commented Jun 4, 2024

See also shorebirdtech/updater#131, which is a source of confusion for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working console
Projects
None yet
Development

No branches or pull requests

2 participants