Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: previous patch was installed after recent patch had been installed. #2198

Closed
hayatshin opened this issue Jun 4, 2024 · 8 comments
Closed
Labels
bug Something isn't working waiting for response Waiting for customer response

Comments

@hayatshin
Copy link

hayatshin commented Jun 4, 2024

I'm not sure, but from my device I guess my app, that had been patched the most recent one, went behind previous patch again.

스크린샷 2024-06-04 오후 11 14 32

patch 6 is the most recent one, and submitted this patch 1 day ago.
And previous patches became 'inactive'.
(patch 5 was also submitted 1 day again but, of course, before patch 6)

스크린샷 2024-06-04 오후 11 15 36

But if you see my Insight page, patch 5 is also installed on 6/4 either even though patch 5 became inactive on 6/3.

Inactive patch can be installed?

And I wonder if it can be also possible scenario that user's app get patch 6, and later, patch 5 or patch 4 overrides the recent patch. Or previous patch overrides the recent one then the recent one overrides again.. something like this.

I found that deletion of previous patch is possible now from console in reply of this below post.
#1380

But I can't find any button yet. Is this right information?

@hayatshin hayatshin added the bug Something isn't working label Jun 4, 2024
@eseidel
Copy link
Contributor

eseidel commented Jun 4, 2024

What's happening here is that we report install events with a lag (on next launch after install). And we record the server time (in utc) when we received the install event, not the install time on the device. We just need to fix this, since you're not the only person who's found this confusing.

shorebirdtech/updater#131
#1761

@hayatshin
Copy link
Author

hayatshin commented Jun 5, 2024

@eseidel Thanks for the fast reply.
Then should I submit patch once again for user to get the most recent patch, or if we wait, user will get the most recent one at the end?
Since another 1 day pasted and even the most recent patch installation becomes 0 (maybe all installation work is finished), my device function is not updated as the most recent patch version.

스크린샷 2024-06-05 오전 9 13 50

@eseidel
Copy link
Contributor

eseidel commented Jun 5, 2024

As soon as you submit patch 2, patch 1 is immediately disabled. No user will get a new download of patch 1. However you might still see patch 1 install events (possibly days or weeks later, depending on how often users launch the app) due to users who has installed patch 1, but not yet restarted their app (since we only send events to our server during patch checks, which happen only during app start). We should fix this since you're not the only person who has found this confusing.

@hayatshin
Copy link
Author

hayatshin commented Jun 7, 2024

@eseidel But my device is not updated as the most recent version of patch and even I tried once again yesterday, but still app is not updated. my App Id is 9eec7268-5f03-4b98-830a-7f465cde0773. Can you check this..?

+) I realized that another app is updated but my app is not updated even I killed my app and restart it several times.
Is there any circumstance that shorebird patch can not be applied?

@eseidel
Copy link
Contributor

eseidel commented Jun 7, 2024

@hayatshin I would love to help, but I'm not sure I understand what is being asked.

@eseidel But my device is not updated as the most recent version of patch and even I tried once again yesterday, but still app is not updated. my App Id is 9eec7268-5f03-4b98-830a-7f465cde0773. Can you check this..?

Sounds like you're suggesting that the app is not updating as you expect?
https://docs.shorebird.dev/troubleshooting/ discusses some common failures. Looking at the logs from the device might help. There is definitely more debugging information we could expose in the console to help.

The most common reason why a patch isn't applied is that the patch is made against a different binary than is installed on the device. shorebird release saves off a private copy of your built app on our servers that then is used by shorebird patch to compare against when making the patch file. That patch file is then only valid for exactly binaries matching the one saved with shorebird release. If somehow a different binary was distributed to the stores then patches won't apply (and will log a failure message in the device logs explaining why).

@erickzanardo
Copy link
Contributor

@hayatshin just checking if Eric's advise helped on realizing why the patch wasn't applied or if you still feel this is an issue/need help?

@erickzanardo erickzanardo added the waiting for response Waiting for customer response label Jun 11, 2024
@hayatshin
Copy link
Author

@erickzanardo yes you can close this issue

@eseidel eseidel closed this as completed Jun 12, 2024
@erickzanardo
Copy link
Contributor

@erickzanardo yes you can close this issue

Thanks for reporting back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting for response Waiting for customer response
Projects
None yet
Development

No branches or pull requests

3 participants