feat(shorebird_cli): add getVersions to ShorebirdFlutter
#1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1063 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 84 84
Lines 3173 3179 +6
=========================================
+ Hits 3173 3179 +6
☔ View full report in Codecov by Sentry. |
bryanoltman
approved these changes
Aug 8, 2023
|
|
||
| Future<List<String>> getVersions({String? revision}) async { | ||
| final result = await git.forEachRef( | ||
| format: '%(refname:short)', |
There was a problem hiding this comment.
Q: is this format string something we want the caller to be responsible for or should it be owned by git? lgtm either way, just curious.
There was a problem hiding this comment.
I left it as is for the sake of flexibility but happy to adjust in the future if we find it's more convenient to keep it internal 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getVersionstoShorebirdFlutter(part of feat: shorebird should support switching flutter versions #1037)Type of Change