feat(shorebird_cli): add channel support to patch and preview commands
#1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 180 180
Lines 4676 4724 +48
=========================================
+ Hits 4676 4724 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
bryanoltman
approved these changes
Oct 2, 2023
Comment on lines
+412
to
+419
| for (final file in Directory(outputPath).listSync(recursive: true)) { | ||
| if (file is File) { | ||
| await encoder.addFile( | ||
| file, | ||
| file.path.replaceFirst('$outputPath/', ''), | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
Not necessary, but a (maybe) more readable way of writing this:
Directory(outputPath).listSync(recursive: true))
.whereType<File>()
.forEach((file) async =>
await encoder.addFile(
file,
file.path.replaceFirst('$outputPath/', ''),
),
);There was a problem hiding this comment.
I just didn't like the having to iterate through the list twice
packages/shorebird_cli/test/src/commands/preview_command_test.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
patchandpreviewcommands (part of feat: support of partial rollouts of patches #783)Type of Change