Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): Add OS wrapper for which/where.exe #1403

Merged
merged 10 commits into from
Oct 16, 2023
Merged

Conversation

bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Oct 16, 2023

Description

Adds the OperatingSystemInterface class, which wraps OS-specific functionality (currently just which/where.exe for locating executables on a user's PATH).

Part of a solution for #1163 and #1213, which involves using the same logic as flutter to find these tools.

See https://github.com/flutter/flutter/blob/stable/packages/flutter_tools/lib/src/android/java.dart#L45-L54 for Java.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5573939) 100.00% compared to head (6e9fb8b) 100.00%.
Report is 1 commits behind head on main.

❗ Current head 6e9fb8b differs from pull request most recent head 298ee66. Consider uploading reports for the commit 298ee66 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1403   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          156       157    +1     
  Lines         4633      4657   +24     
=========================================
+ Hits          4633      4657   +24     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ird_cli/lib/src/os/operating_system_interface.dart 100.00% <100.00%> (ø)
packages/shorebird_cli/lib/src/process.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman requested a review from felangel October 16, 2023 20:14
@bryanoltman bryanoltman enabled auto-merge (squash) October 16, 2023 20:45
@bryanoltman bryanoltman merged commit 27dd48f into main Oct 16, 2023
@bryanoltman bryanoltman deleted the bo/which branch October 16, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants