-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shorebird_cli): Add OS wrapper for which/where.exe #1403
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1403 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 156 157 +1
Lines 4633 4657 +24
=========================================
+ Hits 4633 4657 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Description
Adds the
OperatingSystemInterface
class, which wraps OS-specific functionality (currently justwhich
/where.exe
for locating executables on a user's PATH).Part of a solution for #1163 and #1213, which involves using the same logic as
flutter
to find these tools.See https://github.com/flutter/flutter/blob/stable/packages/flutter_tools/lib/src/android/java.dart#L45-L54 for Java.
Type of Change