fix(shorebird_cli): don't run flutter pub get after build if flutter is not installed
#1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1447 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 151 151
Lines 4579 4580 +1
=========================================
+ Hits 4579 4580 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
felangel
reviewed
Nov 7, 2023
| @@ -277,6 +278,12 @@ mixin ShorebirdBuildMixin on ShorebirdCommand { | |||
| /// https://github.com/shorebirdtech/shorebird/issues/1101 for more info. | |||
| Future<void> _systemFlutterPubGet() async { | |||
| const executable = 'flutter'; | |||
| if (osInterface.which(executable) == null) { | |||
There was a problem hiding this comment.
we really need to get rid of this mixin so we can avoid having to duplicate the tests 🤣
There was a problem hiding this comment.
Yeah, this PR is a case study re: why we shouldn't use mixins for any functionality we want to test :)
felangel
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checks for the presence of flutter on the user's path before attempting to run
flutter pub getafter a build.For context:
flutter pub getis run after a build to reset.dart_tool/package_config.jsonto point to the system flutter install instead of the shorebird flutter install. This value is set when running a flutter build command or flutter pub get.Fixes #1430
Type of Change