Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): fix failing test #1461

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix(shorebird_cli): fix failing test #1461

merged 1 commit into from
Nov 7, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Creates an xcframework as a directory instead of a file.

Fixes the test failure seen in https://github.com/shorebirdtech/shorebird/actions/runs/6788000286/job/18452058897.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman bryanoltman enabled auto-merge (squash) November 7, 2023 17:44
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a1ac60) 100.00% compared to head (0228136) 100.00%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1461   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          151       151           
  Lines         4579      4580    +1     
=========================================
+ Hits          4579      4580    +1     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/shorebird_cli/lib/src/shorebird_build_mixin.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit 843b0b3 into main Nov 7, 2023
8 checks passed
@bryanoltman bryanoltman deleted the bo/fix-tests branch November 7, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants