Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shorebird_cli): move artifact download out of patch diff checker #1545

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

This refactor updates the PatchDiffChecker to accept a File instead of a url, moving the responsibility of downloading release artifacts out of PatchDiffChecker and into the ArtifactManager.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9e3834) 100.00% compared to head (54cd193) 100.00%.

❗ Current head 54cd193 differs from pull request most recent head 9b77ca8. Consider uploading reports for the commit 9b77ca8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1545   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          154       154           
  Lines         4768      4760    -8     
=========================================
- Hits          4768      4760    -8     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman requested review from eseidel and felangel and removed request for eseidel November 29, 2023 20:34
Co-authored-by: Felix Angelov <felix@shorebird.dev>
@bryanoltman bryanoltman enabled auto-merge (squash) November 29, 2023 21:48
@bryanoltman bryanoltman merged commit 6fa62ba into main Nov 29, 2023
6 checks passed
@bryanoltman bryanoltman deleted the bo/diff-checker-download branch November 29, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants