Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): support using linker from local engine #1550

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Dec 6, 2023

Description

  • feat(shorebird_cli): support using linker from local engine

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the enhancement New feature or request label Dec 6, 2023
@felangel felangel self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bce214e) 100.00% compared to head (e237e8a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1550   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          154       154           
  Lines         4766      4783   +17     
=========================================
+ Hits          4766      4783   +17     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

File get _aotToolsFile {
return File(
p.join(
engineConfig.localEngineSrcPath!,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might end up with this as engineConfig.path(....) to avoid and save some chars. 🤷

@felangel felangel merged commit b7cd3a6 into main Dec 6, 2023
@felangel felangel deleted the feat/linker-local-engine branch December 6, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants