-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shorebird_cli): support using linker from local engine #1550
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1550 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 154 154
Lines 4766 4783 +17
=========================================
+ Hits 4766 4783 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
File get _aotToolsFile { | ||
return File( | ||
p.join( | ||
engineConfig.localEngineSrcPath!, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might end up with this as engineConfig.path(....) to avoid and save some chars. 🤷
Description
Type of Change