Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): when using -v, include all process output #1675

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

felangel
Copy link
Contributor

Description

  • fix(shorebird_cli): when using -v, include all process output

Previously we would only show the process output if the process exited with a non-zero exit code. This change makes it so when --verbose is enabled, all process logs are always shown.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Jan 31, 2024
@felangel felangel enabled auto-merge (squash) January 31, 2024 00:19
@felangel felangel merged commit 6c987b9 into main Jan 31, 2024
6 checks passed
@felangel felangel deleted the fix/verbose-mode-includes-all-process-output branch January 31, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants