Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shorebird_code_push_api): engine download endpoint and api key verification #17

Merged
merged 4 commits into from
Mar 6, 2023
Merged

feat(shorebird_code_push_api): engine download endpoint and api key verification #17

merged 4 commits into from
Mar 6, 2023

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Mar 6, 2023 •
edited
Loading

Description

  • Only allow requests with valid API Keys
  • Expose api/v1/engines/<revision> endpoint to download shorebird engine

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the enhancement New feature or request label Mar 6, 2023
@felangel felangel requested a review from eseidel March 6, 2023 17:10
@felangel felangel self-assigned this Mar 6, 2023
@felangel felangel merged commit d2a5ccc into main Mar 6, 2023
@felangel felangel deleted the feat/shorebird-code-push-api-download-engine branch March 6, 2023 17:23
@theappideasankit theappideasankit mentioned this pull request Jul 7, 2023
Closed
@zakblacki zakblacki mentioned this pull request Jul 13, 2023
Closed
@HigorMadeira HigorMadeira mentioned this pull request Sep 12, 2023
Closed
@ilous12 ilous12 mentioned this pull request Apr 2, 2024
Closed
@uc-asa uc-asa mentioned this pull request May 22, 2024
Closed
@eseidel eseidel mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseidel eseidel Awaiting requested review from eseidel

Assignees

@felangel felangel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@felangel