Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shorebird_code_push_updater #22

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Mar 6, 2023

Description

  • feat: add shorebird_code_push_updater

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel requested a review from eseidel March 6, 2023 21:39
@eseidel
Copy link
Contributor

eseidel commented Mar 6, 2023

Do you want it in packages even though it's rust? 🤷

@eseidel
Copy link
Contributor

eseidel commented Mar 6, 2023

Also, this has two copies of the rust code under two different names?

@felangel
Copy link
Contributor Author

felangel commented Mar 6, 2023

Also, this has two copies of the rust code under two different names?

yup just resolved.

@eseidel
Copy link
Contributor

eseidel commented Mar 6, 2023

lgtm.

@felangel
Copy link
Contributor Author

felangel commented Mar 6, 2023

Do you want it in packages even though it's rust? 🤷

Not sure what the conventions are of rust monorepos happy to move it somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants