Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): require Flutter >=3.22.2 for iOS #2218

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

felangel
Copy link
Contributor

Description

  • feat(shorebird_cli): require Flutter 3.22.2 for iOS

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

@felangel felangel self-assigned this Jun 11, 2024
@felangel felangel changed the title feat(shorebird_cli): require Flutter 3.22.2 for iOS feat(shorebird_cli): require Flutter >=3.22.2 for iOS Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (44cab5a) to head (3715b36).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2218   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          186       186           
  Lines         5785      5792    +7     
=========================================
+ Hits          5785      5792    +7     
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felangel felangel merged commit ea06964 into main Jun 11, 2024
11 checks passed
@felangel felangel deleted the feat/enforce-3.22.2-ios branch June 11, 2024 16:09
@yeras-is
Copy link

@felangel is there a way to patch existing iOS apps with older versions like 3.22.1 ? I'm stuck right now with that problem, I have existing release at 3.22.1, but shorebird doesn't allow me to patch existing app because it's version is not above 3.22.2

shorebirdFlutter.getVersion(),
).wait;

if ((flutterVersion ?? minimumSupportedIosFlutterVersion) <

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this rule should apply to new builds and not patches ?

@felangel
Copy link
Contributor Author

@felangel is there a way to patch existing iOS apps with older versions like 3.22.1 ? I'm stuck right now with that problem, I have existing release at 3.22.1, but shorebird doesn't allow me to patch existing app because it's version is not above 3.22.2

We intentionally did this because there were serious bugs in older revisions e.g catch blocks not executing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants