fix(shorebird_cli): shorebird preview to not use outdated cached preview artifacts
#2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
changed the title
erickzanardo
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2254 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 186 186
Lines 5851 5861 +10
=========================================
+ Hits 5851 5861 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
felangel
reviewed
Jun 17, 2024
packages/shorebird_cli/test/src/commands/preview_command_test.dart
Outdated
Show resolved
Hide resolved
felangel
reviewed
Jun 17, 2024
packages/shorebird_cli/test/src/commands/preview_command_test.dart
Outdated
Show resolved
Hide resolved
bryanoltman
approved these changes
Jun 17, 2024
felangel
changed the title
shorebird preview to not use outdated cached preview artifacts
Co-authored-by: Felix Angelov <felix@shorebird.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running a preview, the CLI will always use the cache artifact if one if found. This might make the command run an outdated artifact when a release is delete by some reason.
This PR makes the artifact id to be part of the path of the preview artifact, that way, if a release is deleted and recreated, the id will be a fresh one and the cli will not accidentally use the wrong cached artifact.
Fixes #1746
Type of Change