Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding gradlew version to the doctor output #2255

Merged
merged 10 commits into from
Jun 18, 2024
Merged

feat: adding gradlew version to the doctor output #2255

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
562c905
feat: adding gradlew version to the doctor output
erickzanardo Jun 17, 2024
f6f50f0
adding missing tests
erickzanardo Jun 17, 2024
eb302ae
PR suggestions
erickzanardo Jun 17, 2024
0773648
fixing test on windows
erickzanardo Jun 18, 2024
043833b
PR suggestions
erickzanardo Jun 18, 2024
c0a19f8
PR suggestions
erickzanardo Jun 18, 2024
09d378a
Merge branch 'main' into feat/adding-gradlew-version-to-doctor
erickzanardo Jun 18, 2024
aca166c
pr suggetions
erickzanardo Jun 18, 2024
a322964
better test selector
erickzanardo Jun 18, 2024
dac8f13
improving test platform configuration
erickzanardo Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions packages/shorebird_cli/test/src/executables/gradlew_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,12 +343,34 @@ Make sure you have run "flutter build apk" at least once.''',
});

group('when gradlew exists', () {
test('returns true', () {
File(
p.join(tempDir.path, 'android', 'gradlew'),
).createSync(recursive: true);
expect(gradlew.exists(tempDir.path), isTrue);
});
group(
'when on mac and linux',
() {
test('returns true', () {
File(
p.join(tempDir.path, 'android', 'gradlew'),
).createSync(recursive: true);
erickzanardo marked this conversation as resolved.
Show resolved Hide resolved
expect(gradlew.exists(tempDir.path), isTrue);
});
},
onPlatform: {'windows': const Skip()},
);

group(
'when on windows',
() {
test('returns true', () {
File(
p.join(tempDir.path, 'android', 'gradlew.bat'),
).createSync(recursive: true);
erickzanardo marked this conversation as resolved.
Show resolved Hide resolved
expect(gradlew.exists(tempDir.path), isTrue);
});
},
onPlatform: {
'mac-os': const Skip(),
'linux': const Skip(),
},
);
});
});

Expand Down
Loading