Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): ensure "downloading release" progress completes #2277

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

bryanoltman
Copy link
Contributor

Fixes #2276

Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test?

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e7bb5a7) to head (6400bb9).

Current head 6400bb9 differs from pull request most recent head f5b2202

Please upload reports for the commit f5b2202 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2277   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          186       186           
  Lines         5924      5924           
=========================================
  Hits          5924      5924           
Flag Coverage Δ
shorebird_cli 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman
Copy link
Contributor Author

Can we add a unit test?

Done

@bryanoltman bryanoltman enabled auto-merge (squash) June 20, 2024 18:18
@bryanoltman bryanoltman merged commit 556db89 into main Jun 20, 2024
9 checks passed
@bryanoltman bryanoltman deleted the bo/fix-preview-downloading-release branch June 20, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: "downloading release" progress never terminated in shorebird preview
3 participants