Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding Jetbrains Toolbox Android Studio detection for Linux #2300

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

erickzanardo
Copy link
Contributor

Description

Improves the Android Studio detection on Linux by adding the default installation of the Jetbrains Toolbox app.

On MacOS and Windows there is not need to change since Toolbox seems to install AS in directories that we already check.

Fixes #2297

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@bryanoltman bryanoltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits but LGTM

erickzanardo and others added 2 commits June 28, 2024 11:31
Co-authored-by: Felix Angelov <felix@shorebird.dev>
@erickzanardo erickzanardo requested a review from felangel June 28, 2024 14:40
@erickzanardo erickzanardo merged commit 77309e5 into main Jun 28, 2024
10 checks passed
@erickzanardo erickzanardo deleted the feat/adding-as-detection-jetbrains-toolbox branch June 28, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: shorebird can't detect Android studio when installed via jetbrains toolbox app
3 participants