-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding Jetbrains Toolbox Android Studio detection for Linux #2300
Merged
erickzanardo
merged 3 commits into
main
from
feat/adding-as-detection-jetbrains-toolbox
Jun 28, 2024
Merged
feat: adding Jetbrains Toolbox Android Studio detection for Linux #2300
erickzanardo
merged 3 commits into
main
from
feat/adding-as-detection-jetbrains-toolbox
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
felangel
reviewed
Jun 28, 2024
felangel
reviewed
Jun 28, 2024
felangel
reviewed
Jun 28, 2024
felangel
reviewed
Jun 28, 2024
felangel
reviewed
Jun 28, 2024
bryanoltman
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits but LGTM
Co-authored-by: Felix Angelov <felix@shorebird.dev>
felangel
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the Android Studio detection on Linux by adding the default installation of the Jetbrains Toolbox app.
On MacOS and Windows there is not need to change since Toolbox seems to install AS in directories that we already check.
Fixes #2297
Type of Change