fix(shorebird_cli): always respect build-name and build-number args #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
bryanoltman
commented
Jun 28, 2024
erickzanardo
approved these changes
Jul 1, 2024
felangel
reviewed
Jul 1, 2024
felangel
reviewed
Jul 1, 2024
| /// Provides the [containsAnyOf] method to all [Iterable]s. | ||
| extension ContainsAnyOf<T> on Iterable<T> { | ||
| /// Returns `true` if any of the elements in [elements] are in this iterable. | ||
| bool containsAnyOf(Iterable<T> elements) => elements.any(contains); |
There was a problem hiding this comment.
What’s the benefit of this extension? Seems like it’s a one liner either way
There was a problem hiding this comment.
It looks a bit nicer with list literals:
argResults.options.containsAnyOf([a,b]);instead of
[a,b].any((e) => argResults.options.contains(e));Mostly just a minor readability improvement, happy to remove if you feel strongly.
felangel
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were previously only using
build-numberfor Flutter module releases. Because this argument is respected for allflutter buildoperations, we should support it for all of them if we support it at all.Fixes #2301
Type of Change