Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow user to choose organization in shorebird init #2514

Merged
merged 12 commits into from
Oct 8, 2024

Conversation

bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Oct 7, 2024

Description

When running shorebird init, ask the user to specify an organization for the app if the user is a member of multiple organizations.

Screenshot 2024-10-07 at 5 49 58 PM

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Base automatically changed from bo/get-organization-memberships to main October 7, 2024 19:58
@bryanoltman bryanoltman marked this pull request as ready for review October 7, 2024 21:46
@bryanoltman
Copy link
Contributor Author

I could see wanting to rephrase "Personal" as "(None)" or similar, depending on if we expect users to think of "apps in personal organizations" as "apps without an organization"

@felangel
Copy link
Contributor

felangel commented Oct 7, 2024

I could see wanting to rephrase "Personal" as "(None)" or similar, depending on if we expect users to think of "apps in personal organizations" as "apps without an organization"

I would probably list their display name (email fallback) to stay consistent with the console

@eseidel
Copy link
Contributor

eseidel commented Oct 8, 2024 via email

@bryanoltman bryanoltman merged commit 238837f into main Oct 8, 2024
15 checks passed
@bryanoltman bryanoltman deleted the bo/init-organization-choice branch October 8, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants