-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow user to choose organization in shorebird init #2514
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
I could see wanting to rephrase "Personal" as "(None)" or similar, depending on if we expect users to think of "apps in personal organizations" as "apps without an organization" |
I would probably list their display name (email fallback) to stay consistent with the console |
Prompt lgtm
…On Tue, Oct 8, 2024 at 11:55 AM Bryan Oltman ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/shorebird_cli/lib/src/extensions/organization.dart
<#2514 (comment)>
:
> @@ -0,0 +1,12 @@
+import 'package:shorebird_code_push_protocol/shorebird_code_push_protocol.dart';
+
+/// ***@***.*** organization_display}
+/// Returns the user-facing display name of an [Organization].
+/// ***@***.***}
+extension OrganizationDisplay on Organization {
+ /// ***@***.*** organization_display}
+ String get displayName => switch (organizationType) {
+ OrganizationType.team => name,
+ OrganizationType.personal => 'Personal',
Screenshot.2024-10-08.at.2.54.48.PM.png (view on web)
<https://github.com/user-attachments/assets/9d11509a-98d4-4c34-9a52-cdf33bdd929a>
So something like this, you think?
—
Reply to this email directly, view it on GitHub
<#2514 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADU2TM33ULBQVASMHKJQDLZ2QTDRAVCNFSM6AAAAABPQLFRRSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNJVGI4TEMRTGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Description
When running
shorebird init
, ask the user to specify an organization for the app if the user is a member of multiple organizations.Type of Change