Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add URL reachability checks to shorebird doctor #2537

Merged
merged 1 commit into from
Oct 15, 2024
Merged

feat: add URL reachability checks to shorebird doctor #2537

merged 1 commit into from
Oct 15, 2024
+139 −2

Conversation

bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Oct 15, 2024 •
edited
Loading

Description

Screenshot 2024-10-15 at 2 47 18 PM

Fixes #2535

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

eseidel
eseidel approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I suspect we might also want to check shorebird.cloud (our CDN) and storage.google.com? But lgtm!

@bryanoltman
Copy link
Contributor Author

@eseidel yep, decided to break that out into a separate ticket #2536

@bryanoltman bryanoltman merged commit cec1bf5 into main Oct 15, 2024
10 checks passed
@bryanoltman bryanoltman deleted the bo/network-reachability branch October 15, 2024 18:49
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@bryanoltman
Copy link
Contributor Author

@eseidel er, read your comment too quickly. Will update :)

@bryanoltman bryanoltman mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseidel eseidel eseidel approved these changes

@felangel felangel Awaiting requested review from felangel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: make doctor network reachability check more robust
2 participants
@bryanoltman @eseidel