fix: choose newest xcarchive in ios release #2577
Merged
+70
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseidel
reviewed
Oct 24, 2024
eseidel
approved these changes
Oct 24, 2024
Co-authored-by: Eric Seidel <eric@shorebird.dev>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
felangel
approved these changes
Oct 24, 2024
| // This still could grab the wrong ipa, if multiple `flutter` commands | ||
| // are running in parallel or the clock is/was broken on the machine. | ||
| // If either of those occurs in the wild we can check the contents of | ||
| // the xcarchives, but this should be good enough for now. |
There was a problem hiding this comment.
@bryanoltman
Isn't this crucial?
As the bug in the shorebird release itself, this will break patching too not just previewing. Developer will get a confirmation of the patch successfully published but it'll never be installed for app users.
There was a problem hiding this comment.
It is indeed crucial. We believe that it is a "good enough" fix, in that it will solve the problem in 99.9% of cases, except those outlined in the comment above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the ArtifactManager's
getXcarchivefunction to return the most recently edited xcarchive rather than the first that appears inDirectory.listSyncFixes #2575 and #2549
Type of Change