-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shorebird_cli): add shorebird release get-apks
command
#2586
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Sorry I didn't weigh in on this earlier but I feel like the simpler solution would've been to adjust Update: opened a PR with my suggested solution at #2587 |
This comes up often. I'm not particularly wedded to one solution or the other (approved Felix's just because it was earlier in my inbox and I approve things sent to me). Downloading the AAB and running bundletool are two things which are hard to do. Unclear if they should be tied together, but users don't know how to do either without our assistance. The logging solution Felix posted maybe is enough? The intent for preview might be different from the intent from this command however. Both need to have keystores in order to build the apk from an aab, the "preview" one might be using a local signing keystore, where as some other command might be using some sort of release key-store. Although one could argue if you're doing release work, why isn't it just from the original |
Yeah I'm not strongly opposed to a new command was just mostly trying to offer a simpler alternative that I believe would address the customer ask 🤷 |
'Building apks for release ${release.version} (app: $appId)', | ||
); | ||
try { | ||
await bundletool.buildApks(bundle: aabFile.path, output: apksFile.path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shorebird preview
has almost identical logic so it would be nice to refactor to share more code rather than having this implementation live in two separate commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to, although the code shared between here and preview is split across several different places to accommodate both iOS and Android, and has a preview-specific cache that I was a bit hesitant to interact with here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This specific bit of code has also diverged, as preview always generates a universal APK and this command offers a way to disable that, so I'm less certain how much can be shared
shorebird release get-apk
commandshorebird release get-apks
command
Description
Adds the
shorebird release get-apks
command, which enables the creation of either a universal APK or spilt APKs from an existing Shorebird release.Fixes #2423
Type of Change