Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace --staging with --channel in patch command #2608

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

bryanoltman
Copy link
Contributor

Description

Updates the patch command to accept the --channel argument (which defaults to stable). Currently accepted values are staging and stable. This replaces --staging, which now prints a deprecation error.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

@felangel
Copy link
Contributor

felangel commented Nov 7, 2024

Rather than making this a breaking change we could add the beta flag and enforce that only one is provided. Also we should align on naming (track vs channel) and be consistent throughout the cli and code push package

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@bryanoltman
Copy link
Contributor Author

Rather than making this a breaking change we could add the beta flag and enforce that only one is provided. Also we should align on naming (track vs channel) and be consistent throughout the cli and code push package

We could, but we'd effectively be using bool flags for what is actually an enum, which gets nasty if/when we add more and we'd have to decide which takes precedence when more than one are passed.

@felangel
Copy link
Contributor

felangel commented Nov 7, 2024

Rather than making this a breaking change we could add the beta flag and enforce that only one is provided. Also we should align on naming (track vs channel) and be consistent throughout the cli and code push package

We could, but we'd effectively be using bool flags for what is actually an enum, which gets nasty if/when we add more and we'd have to decide which takes precedence when more than one are passed.

Yeah that’s fair I’m fine with the change just want to make sure we are consistent in the naming (channel vs track). I personally think of the pre-defined channels as tracks but don’t have a strong opinion as long as we’re consistent🤷

@bryanoltman
Copy link
Contributor Author

sg, renamed "channel" to "track"

@bryanoltman bryanoltman merged commit 9894407 into main Nov 7, 2024
11 checks passed
@bryanoltman bryanoltman deleted the bo/channel-patch-arg branch November 7, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants