Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shorebird_cli): recognize flavors in Flutter modules #569

Merged
merged 1 commit into from
May 31, 2023
Merged

feat(shorebird_cli): recognize flavors in Flutter modules #569

merged 1 commit into from
May 31, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Updates ShorebirdFlavorMixin to check for android and .android directories for product flavors.

Fixes #568

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

felangel
felangel approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@bryanoltman bryanoltman merged commit efda257 into main May 31, 2023
@bryanoltman bryanoltman deleted the bo/module-flavors branch May 31, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@eseidel eseidel Awaiting requested review from eseidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(shorebird_cli): recognize app flavors in Flutter modules
2 participants
@bryanoltman @felangel