Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shorebird_cli): shorebird init fail on flavor detection error #735

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

felangel
Copy link
Contributor

Description

  • fix(shorebird_cli): shorebird init fail on flavor detection error
    • detect missing gradlew and provide instructions for how to resolve.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel self-assigned this Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cf312f5) 100.00% compared to head (ae6adba) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #735   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           72        72           
  Lines         2539      2546    +7     
=========================================
+ Hits          2539      2546    +7     
Impacted Files Coverage Δ
...s/shorebird_cli/lib/src/commands/init_command.dart 100.00% <100.00%> (ø)
.../shorebird_cli/lib/src/shorebird_flavor_mixin.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@felangel felangel merged commit cad3310 into main Jun 29, 2023
@felangel felangel deleted the fix/shorebird-cli-fail-on-flavor-detection-error branch June 29, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants