-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shorebird_code_push_protocol): add RecordPatchInstallRequest type #826
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 87 73 -14
Lines 3299 836 -2463
===========================================
- Hits 3299 836 -2463
☔ View full report in Codecov by Sentry. |
Moving this to a draft state until we decide how we want to charge for overages. |
@felangel let me know if there's any information we'd want in the logs that isn't in this request. My thinking was that we could just log this request as json and get all the info we need from that. |
I think we'd need more info (client_id, app_id, release_id, platform, arch, patch_id, timestamp) but we can get the remaining info on the backend. |
|
…horebird into bo/patch-install-request
Description
Introduces a
RecordPatchInstallRequest
type to record successful patch installs on client devices.Part of https://github.com/shorebirdtech/_shorebird/issues/281
Type of Change