Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_code_push_protocol): add RecordPatchInstallRequest type #826

Merged
merged 10 commits into from
Aug 9, 2023

Conversation

bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Jul 11, 2023

Description

Introduces a RecordPatchInstallRequest type to record successful patch installs on client devices.

Part of https://github.com/shorebirdtech/_shorebird/issues/281

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b249d76) 100.00% compared to head (7aea994) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #826     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           87        73     -14     
  Lines         3299       836   -2463     
===========================================
- Hits          3299       836   -2463     
Files Changed Coverage Δ
...rd_patch_install/record_patch_install_request.dart 100.00% <100.00%> (ø)
..._patch_install/record_patch_install_request.g.dart 100.00% <100.00%> (ø)

... and 158 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman
Copy link
Contributor Author

Moving this to a draft state until we decide how we want to charge for overages.

@bryanoltman bryanoltman marked this pull request as draft July 12, 2023 14:40
@bryanoltman bryanoltman changed the title feat(shorebird_code_push_protocol): add CreatePatchInstallRequest type feat(shorebird_code_push_protocol): add RecordPatchInstallRequest type Aug 9, 2023
@bryanoltman bryanoltman marked this pull request as ready for review August 9, 2023 20:06
@bryanoltman
Copy link
Contributor Author

@felangel let me know if there's any information we'd want in the logs that isn't in this request. My thinking was that we could just log this request as json and get all the info we need from that.

@felangel
Copy link
Contributor

felangel commented Aug 9, 2023

@felangel let me know if there's any information we'd want in the logs that isn't in this request. My thinking was that we could just log this request as json and get all the info we need from that.

I think we'd need more info (client_id, app_id, release_id, platform, arch, patch_id, timestamp) but we can get the remaining info on the backend.

@bryanoltman
Copy link
Contributor Author

bryanoltman commented Aug 9, 2023

  • client_id – in request
  • app_id – in request
  • release_id – added to request
  • platform – added to request
  • arch – added to request
  • patch_id – I think this can be easily queried for if we need it, not sure the updater has this info currently
  • timestamp – It would probably be better to get this from the request log, as there's not a guarantee that user devices will have their clocks set correctly.

@bryanoltman bryanoltman merged commit 03fec3f into main Aug 9, 2023
@bryanoltman bryanoltman deleted the bo/patch-install-request branch August 9, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants