feat: Add support for proxy config #229
Conversation
Added proxy_url to shorebird.yaml to use with reqwest if specified
library/src/network.rs
Outdated
| Ok(client) | ||
| } | ||
|
|
||
| fn read_config() -> anyhow::Result<YamlConfig> { |
There was a problem hiding this comment.
I think typically config is set through https://github.com/shorebirdtech/updater/blob/main/library/src/config.rs#L91
There was a problem hiding this comment.
I see, looks like the request callbacks would now need to be config-specifc. 🤔
|
I'm open to this change. The use case of "we want to use Shorebird behind a corporate network" makes sense. It is unfortunate that we can't (easily) fix this by using whatever existing network interface was already correctly configured. It feels wrong to have to configure Shorebird's https client specifically. I think the only thing blocking this landing is one of us fiddling with how to plumb the shorebird.yaml reading through to where it's normally done (and also probably change how the network callbacks are created). |
|
Removed the proposed yaml config var in favor of reqwest pulling the system proxy for us. |
|
If this change works, it makes a lot of sense and would be easy for us to land. Thoughts @bryanoltman? |
|
My guess is this won't work, unless reqwest has iOS or Android specific code to read the proxy config (which I doubt it has). We also presumably would have to add the "socks" option to our reqwest import: |
Description
Added
proxy_urlto shorebird.yaml to use with reqwest client innetwork.rs(if defined)Type of Change