-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMY Arduino drum and fm examples on ESP32S3 cause restart #135
Comments
Nice, thanks for checking out AMY! I'll take a look at the Arduino examples asap. It's most likely they got out of sync -- we've been fully on Tulip the past couple of months and probably messed that up. The FM example in |
Still no joy with getting sound from the fm example on either of my projects after replacing examples.c. There must be something else that needs changing. |
Just to make sure, change the velocity to much higher -- it's a very faint tone and may not show up on your DAC. Like change line 321 of And if you're using Arduino, make sure you delete and re-copy the AMY repository (checked out from the |
I've confirmed that examples.c in both of my projects are the current one and changed the volume as suggested but no luck with either project. I downloaded the AMY repo a couple of days ago and was working with that but now I've done a git clone for my latest test. Tomorrow morning I will start fresh in case I've messed something up along the way :-) Thanks for pursuing this! |
I looked at this again to make sure I'm building the fm example with the modified examples.c and have added the velocity statement and there is no sound with either the esp32s3 or the MacOs application. |
I've gone and made the |
No sound on Mac could be using the wrong audio device, I.e. needs |
The MacOS version works perfectly now. I built my previous version using XCode and maybe I messed something up or Clang compiles something that is incompatible? I tried again with Xcode and the updated amy-example.c and get no sound from the fm tone (but do get sound from the voice chord). I don't know why I used Xcode as I much prefer the Makefile/Gcc method. Sorry Brian if I sent you on wild goose chase with that! |
Sorry I spoke too soon. In the Xcode project I had changed the call to note_on_mod() in algorithms.c to agree with it's definition and the fm tone didn't work. Just to be clear, in algorithms.c at line 123 this is the call: note_on_mod(synth[osc].algo_source[i], osc); and the definition in line 99 is: void note_on_mod(uint16_t osc, uint16_t algo_osc) which I thought was causing the crash in the Arduino example but perhaps it is something else. Changing the order of the parameters in the call did fix the crash but didn't generate the tone. |
The Having a bit of trouble following our troubleshooting, don't mind me -- are you hearing audio output with unmodified |
Yes everything is fine with the MacOS version now. As for the Arduino example when I used the debugger I saw that the first parameter which is an index into the array was 0xFFFF so I thought that the order of the parameters was wrong but I guess I just jumped to that conclusion because of the naming. Probably a red herring. |
ok great!! When I'm back up at my studio this week I'll test some Arduino examples. Thanks for your help, I'll be back! |
Anything I can do to help let me know. I am slowly figuring out how things work and loving it! Both AMY and Tulip are amazing projects (and of course Alles too although I haven't spent much time with it yet). |
Also pasting in a similar report from discord user
I'll be taking a look at this stuff this week. |
OK, I think I fixed the drums restarting. See #142 but we were not resetting the oscs before changing the wave type. It's not clear why this crashes only on ESP32, but it's not something you're meant to do, so I just added an explicit reset in I've also tested the (Now louder) |
I'm not clear about the intent of the logic in |
I'm experimenting with AMY and ran into the problems mentioned in the title. I'm building with PlatformIO using a project template that I've used many times before. The I2S device is a PCM5102A board which I got to work with some effort and the two sine wave and the voice_chord examples run as expected.
Since I'm using PlatformIO I ran the fm and drum examples under the debugger and found the source of the crashing for the fm one. This is because in algorithms.c at line 123 the order of the arguments is reversed from what is expected causing an array out of bounds error that is doing something bad. Changing that fixed the crashing but there is no sound generated.
I couldn't find the source of the crashing for the drum example so I built the desktop example for MacOS. In this case the drum example does run fine. The fm example however gives a sawtooth like sound without the fix and no sound when the fix is applied.
I wondering if the examples got out of sync with the library somewhere along the way? I did go through the commits over the past few months but couldn't see anything obvious.
BTW I really like the Tulip concept and have ordered a Tulip CC from Makerfabs. I also have some other things I would like to try with AMY itself or maybe a scaled down Tulip with no user interface except for configuration and control via MIDI.
The text was updated successfully, but these errors were encountered: