Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SG-32806 Enable support for Python 3.10 in CI #301

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

carlos-villavicencio-adsk
Copy link
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk commented Sep 8, 2023

We need to rebase #305 and complete SG-32847 before testing this again.

  • ssl.PROTOCOL_TLS is deprecated
    • Upgrades httplib2 module
  • ssl.wrap_socket() is deprecated, use SSLContext.wrap_socket()
    • Upgraded syntax
  • module 'sre_constants' is deprecated (only on Python 3.11)
    • pyparsing should be upgraded. We can work on this later since this needs more testing.

@carlos-villavicencio-adsk carlos-villavicencio-adsk marked this pull request as draft September 11, 2023 15:28
@carlos-villavicencio-adsk carlos-villavicencio-adsk changed the title SG-32657 Test CI with Python 3.10 SG-32806 Test CI with Python 3.10 Sep 18, 2023
README.md Outdated Show resolved Hide resolved
azure-pipelines-templates/run-tests.yml Outdated Show resolved Hide resolved
shotgun_api3/shotgun.py Show resolved Hide resolved
Copy link
Contributor

@NorberMV NorberMV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Contributor

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos-villavicencio-adsk what about the Chorus warnings? Anything we can do to avoid them? Any comment pattern to silent them?

@carlos-villavicencio-adsk
Copy link
Contributor Author

carlos-villavicencio-adsk commented Sep 21, 2023

@carlos-villavicencio-adsk what about the Chorus warnings? Anything we can do to avoid them? Any comment pattern to silent them?

We cannot avoid them without completely removing the Python 2 support. The warning is on the existing legacy code we have. We can skip them, it's on the same invocation.

@carlos-villavicencio-adsk carlos-villavicencio-adsk changed the title SG-32806 Test CI with Python 3.10 SG-32806 Enable support for Python 3.10 in CI Sep 21, 2023
@carlos-villavicencio-adsk carlos-villavicencio-adsk merged commit 7cb3367 into master Sep 22, 2023
21 checks passed
@carlos-villavicencio-adsk carlos-villavicencio-adsk deleted the ticket/SG-32657_py310 branch September 22, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants