SG-34910 Fixup SSLEOFError exception #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-lang
requested review from
carlos-villavicencio-adsk and
eduardoChaucaGallegos
eduardoChaucaGallegos
approved these changes
Jun 5, 2024
julien-lang
force-pushed
the
ticket/SG-34910-fixup-ssl-eol-exception
branch
from
e626ed4
to
f9f50d3
Compare
carlos-villavicencio-adsk
approved these changes
Jun 6, 2024
| # the connection and make a new attempt. | ||
| LOG.debug("SSLEOFError: {}".format(e)) | ||
| self._close_connection() | ||
| if attempt == max_rpc_attempts: |
There was a problem hiding this comment.
self.config.max_rpc_attempts is hardcoding the value of 3. Maybe we can now get rid of this one and use self.MAX_ATTEMPTS instead. WDYT?
There was a problem hiding this comment.
Hardcoded yes and no. It's the default value of the config object but users can select a different value.
Also, I see that this variable is still used at other places. So I kind of want to keep it as is for the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the existing re-attempt strategy in case of SSLEOFError