SG-35018 Remove Ticket entity reference and prepare this to run in CI #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-villavicencio-adsk
requested review from
julien-lang and
eduardoChaucaGallegos
eduardoChaucaGallegos
previously approved these changes
Jun 19, 2024
julien-lang
reviewed
Jun 19, 2024
| filters = [['sg_priority', 'in', self.ticket['sg_priority'], '1'], | ||
| ['project', 'is', self.project]] | ||
|
|
||
| result = self._id_in_result('Ticket', filters, self.ticket['id']) |
There was a problem hiding this comment.
Not equivalent with Version on these ones ?
There was a problem hiding this comment.
Good call! I just replaced them and got these tests back. Thank you!
carlos-villavicencio-adsk
changed the title
carlos-villavicencio-adsk
deleted the
ticket/SG-35018_remove_Ticket_entity_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket entity is disabled by default on ShotGrid (it seems so).
I'm making unit tests dependant-free on this entity. It seems they were enabled when these tests were implemented, but now this is making it harder to test locally with fresh SG sites.