-
Notifications
You must be signed in to change notification settings - Fork 206
SG-40841 Add information about relative_path field #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation for the relative_path field in local file links throughout the attachments cookbook. The relative_path field represents the file path relative to the local_storage root directory.
Key changes:
- Added
relative_pathfield definition to the field documentation section - Updated all code examples to include the
relative_pathfield in their output - Improved JSON formatting consistency across examples
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Good thing that you removed the urls from the loca_storage...
One small detail, half the changed examples has a trailing comma while the other half do not. (Consistency is always best, but I see that it was already this way before, I do not believe that we want to fix all that...)
3e5f2dd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request updates the documentation in
docs/cookbook/attachments.rstto improve clarity and completeness regarding local file attachment fields. The changes focus on formatting consistency, introducing therelative_pathfield, and updating example code blocks to match the latest data structure.