Remove rerun-if-env-changed #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
remove-if-env-changed
branch
from
46ef7ba
to
1264bb8
Compare
This was referenced Aug 14, 2023
conorbros
approved these changes
Aug 14, 2023
benbromhead
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented here: rust-lang/cargo#12482
We should not be using rerun-if-env-changed here.
It causes needless rebuilds when running
cargo buildfrom within our binary and that happens within tokio-bin-process's BinProcess::start_crate_nameHowever we cannot have no rerun clauses as that causes cargo to rebuild every time.
So instead we do the documented workaround of adding
rerun-if-changed=build.rs: https://doc.rust-lang.org/cargo/reference/build-scripts.html#cargorerun-if-changedpath