Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream FuturesOrdered::prepend #285

Closed
rukai opened this issue Oct 20, 2021 · 3 comments
Closed

Upstream FuturesOrdered::prepend #285

rukai opened this issue Oct 20, 2021 · 3 comments
Assignees
@conorbros

Comments

@rukai
Copy link
Member

rukai commented Oct 20, 2021

Describe the bug

We should not be vendoring random library code, instead lets upstream our custom FuturesOrdered::prepend method to https://github.com/rust-lang/futures-rs
@benbromhead
Copy link
Member

See rust-lang/futures-rs#2309
I'll get on to it once we have released shotover

@conorbros conorbros self-assigned this Jun 9, 2022
@conorbros
Copy link
Member

Update on this: I've opened a PR on futures-rs. Once it's merged we can use that instead and close this.

@rukai
Copy link
Member Author

rukai commented Nov 22, 2022

Closed by #698

@rukai rukai closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conorbros conorbros

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rukai @benbromhead @conorbros