Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use future-rs latest #698

Merged
merged 12 commits into from
Aug 17, 2022
Merged

use future-rs latest #698

merged 12 commits into from
Aug 17, 2022

Conversation

conorbros
Copy link
Member

Now that rust-lang/futures-rs#2591 has been merged we can use the latest futures-rs version from git and remove the library code from our repo.

This PR is mostly just adding required traits and fixing some formatting.

@conorbros conorbros requested a review from rukai July 7, 2022 06:41
@rukai
Copy link
Member

rukai commented Jul 8, 2022

Importing both futures git and futures_util 3.0 seems really wonky to me.
The reason is that futures reexports parts of futures_util.
This means we have traits from 2 versions of futures_util floating around which will cause a lot of confusion and hard to understand errors.

The release process for futures-rs isnt really documented, but by examining these release PRs it appears taiki will manually backport some PRs from master onto the 0.3 branch and then make a release.
rust-lang/futures-rs#2563

So I suggest we put this PR on hold until either a 0.3 backport or a 0.4 release

shotover-proxy/Cargo.toml Outdated Show resolved Hide resolved
@conorbros conorbros marked this pull request as draft July 12, 2022 02:46
@conorbros
Copy link
Member Author

Marking as a draft until a new version of futures-rs is released.

shotover-proxy/Cargo.toml Outdated Show resolved Hide resolved
@conorbros conorbros marked this pull request as ready for review August 15, 2022 00:18
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to rebase

@conorbros conorbros merged commit 832b836 into shotover:main Aug 17, 2022
@conorbros conorbros deleted the upstream-futures-rs branch August 17, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants