Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all TcpStream::connect are wrapped in a timeout #769

Closed
rukai opened this issue Aug 30, 2022 · 0 comments · Fixed by #774
Closed

Ensure all TcpStream::connect are wrapped in a timeout #769

rukai opened this issue Aug 30, 2022 · 0 comments · Fixed by #774
Assignees
@conorbros

Comments

@rukai
Copy link
Member

rukai commented Aug 30, 2022

TcpStream::connect will block indefinitely in some cases (I assume when the destination just completely ignores us or doesnt exist)
We should add a timeout to all TcpStream::connects so that if a destination node goes down shotover doesnt get stuck and will instead return an error or retry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conorbros conorbros

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add timeout to new tcp connections conorbros/shotover-proxy
2 participants
@rukai @conorbros