add timeout to new tcp connections #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorbros
force-pushed
the
tcp-stream-timeout
branch
from
f22ea7d
to
ecc5078
Compare
rukai
reviewed
Aug 31, 2022
rukai
reviewed
Aug 31, 2022
rukai
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
LGTM
I think we are fine using a hardcoded timeout for a connection because we always want at least some timeout here and its not like a query where we might have to wait for the server to do some complex operation.
3s is possibly a bit short but its what RedisSinkCluster is already doing 🤷
benbromhead
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #769