Fix prepare messages opening unneccessary connections #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
fix_prepare_messages_opening_unneccessary_connections
branch
from
d1922ec
to
50caa85
Compare
conorbros
approved these changes
Jan 31, 2023
benbromhead
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #978
Previously they would open against every node in the data center, instead we now only open against every node in the rack.
We make use of the RewriteTableTy::Prepare because that way we ensure the connections we open matches whatever nodes we will end up sending our prepare messages to, even if the logic for determining prepare nodes changes in the future.