remove Frame::None #1046
Merged
remove Frame::None #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Nice catch!
I think that, semantically, Frame::None makes a bit more sense than Frame::Redis(RedisFrame::Null) in redis/sink_cluster.rs
As it conveys the lack of a message rather than a null redis message.
But Frame::Redis(RedisFrame::Null) does work just fine here, so I'm more than happy to make the swap here to allow us to remove Frame::Null
benbromhead
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was originally intended to mean "null" of redis frame but it's prevalence has gone beyond the scope of that. We can just use
RedisFrame::Null.