Kafka: fix flexible version handling #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
kafka_flexible_version_fix
branch
from
97588b7
to
b76edb4
Compare
rukai
force-pushed
the
kafka_flexible_version_fix
branch
from
b76edb4
to
f571af0
Compare
conorbros
approved these changes
Mar 1, 2023
benbromhead
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1056
I managed to upstream the logic for converting an api version to a header version.
Refer to tychedelia/kafka-protocol-rs#21 and tychedelia/kafka-protocol-rs#22 for more info.
In order to avoid manually parsing the api_key and api_version we should one day upstream some wrappers to kafka-protocol-rs that does this for us.
For now we can land this PR as it fixes our header version issue.