Make TransformConfig into a trait #1064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To achieve this, we sprinkle in some dtolnay magic crates:
And finally we need a custom deserialize implementation for our chain config.
The problem was that typetagged structs with no fields would not deserialize from a yaml string.
e.g.
this would fail to deserialize:
but this would work fine:
I do not really understand what the
vec_transform_config
custom deserializer is doing, but it clearly does fix the issue, allowing us to write our config asNullSink
instead ofNullSink: {}
.I can do a thorough investigation to better understand it if needed.
The implementation was a suggestion from dtolnay: dtolnay/typetag#40 (comment)
This solution does add a bunch of complexity but it is at least hidden away in its own module and doesn't affect users of the API.