Add ShotoverProcessBuilder::with_observability_address #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
shotover_process_with_observability_address
branch
from
377be23
to
67c5142
Compare
rukai
force-pushed
the
shotover_process_with_observability_address
branch
from
67c5142
to
b70c1d3
Compare
conorbros
reviewed
Mar 10, 2023
conorbros
approved these changes
Mar 10, 2023
benbromhead
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to correctly configure shotover in integration tests with multiple shotover instances.
Previously we had to tell BinProcess to ignore the resulting error.
Generating config for this is not ideal, but we currently dont expose this as a CLI flag, and I dont want to block this improvement on figuring out what our CLI/config.yaml split should look like.