Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kafka encode error #1076

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

rukai
Copy link
Member

@rukai rukai commented Mar 13, 2023

Drastically improves usefulness of error.
Previously:

shotover   00:08:06.689555Z ERROR connection{id=3 source="KafkaSource"}: shotover_proxy::server: failed to send or encode message: EncodeError

Now:

shotover   00:21:14.715015Z ERROR connection{id=2 source="KafkaSource"}: shotover_proxy::server: failed to send or encode message: Failed to encode kafka_protocol::messages::find_coordinator_response::FindCoordinatorResponse v4 body

Caused by:
    EncodeError

Matches the format of error given for a decode error.

@conorbros conorbros merged commit 4d19376 into shotover:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants