Fix invalid modifications to FindCoordinator responses #1077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the encoder expects protocols >= 4 to have all the removed fields set to 0 (or equivalent default value)
We were just setting all the port fields regardless of version causing the encoder to return an error when a modern protocol was used.
Now we only set the port fields that are actually available in the specific version of the message.
You can verify this fixes the issue by simultaneously running these scripts that come with kafka against
test-configs/kafka/passthrough/topology.yaml
:and
Then sending a message through the producer and observing it appear in the consumer.
Before this fix, we would hit the encode error and nothing would appear in the consumer.