Return error message to client when chain fails to send/receive #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
return_errors_to_client_when_chain_fails
branch
from
97c0ca8
to
d8b0a59
Compare
rukai
force-pushed
the
return_errors_to_client_when_chain_fails
branch
from
d8b0a59
to
fa0206e
Compare
benbromhead
approved these changes
Mar 16, 2023
conorbros
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is useful for the reasons I wrote about in the code comment.
However it does come at a performance cost - there is now one extra allocation per incoming message batch. (just for the vec, the
Messages themselves do not allocate)I still think its worth it though.
An easy way to test this new handling is to run a shotover config without a database running at the destination address.