-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks for kafka #1085
Add benchmarks for kafka #1085
Conversation
I wonder if it's more worth our time starting with a mock kafka like we have for Cassandra. |
Yep, I think a mock kafka would be nice, ultimately we still need a real kafka bench as well because it demonstrates performance in a more realistic scenario. |
15 benchmark regressed. 0 benchmark improved. Please check the benchmark workflow logs for full details: https://github.com/shotover/shotover-proxy/actions/runs/4443429016
|
Adds benchmarks for kafka using the
kafka-producer-perf-test.sh
script that comes with kafka.The results of
kafka_bench.rs
is that shotover has the same throughput as a direct connection:However I do not really trust these results, I suspect the bencher is only single threaded and therefore isnt putting a proper load on shotover or kafka.
We can further investigate a better benchmarker but for now lets land these benches as they are a useful starting point.
The benchmarks also do not measure encoding/decoding time as a simple shotover setup does not trigger encoding/decoding.