Split shotover library/binary into separate crates #1102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming is up for discussion but I am proposing:
shotover
shotover-proxy
shotover-proxy
to match upstream if they desire, previously that was impossible because of the collision with the library name.The
shotover
library will contain all of shotover, theshotover-proxy
binary is just there to statically link in custom transforms.Alternatives:
Shotover the product is called just "shotover" instead of "shotover proxy" these days.
So the
-proxy
postfix doesnt mean as much, maybe we should go for something more descriptive likeshotover-bin
?