Cassandra protocol v5 #1104
Merged
Cassandra protocol v5 #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I'll pull out that flamegraph change. - |
conorbros
commented
Mar 28, 2023
8 tasks
conorbros
force-pushed
the
protocol-v5-refactor
branch
from
1df5a95
to
76553b1
Compare
rukai
reviewed
Mar 28, 2023
rukai
reviewed
Mar 28, 2023
rukai
reviewed
Mar 28, 2023
rukai
reviewed
Mar 28, 2023
|
I've realized that none of our benchmarks are actually running in protocol v5:
We will need to get access to some benchmarks before we can land this as modern drivers will enable v5 by default. A way avoid this unbenchmarked protocol support from hitting production while still landing this PR would be setting a feature flag (that is enabled in tests) such that we reject any attempts to connect with v5 for now. |
rukai
reviewed
Mar 29, 2023
rukai
reviewed
Mar 29, 2023
conorbros
force-pushed
the
protocol-v5-refactor
branch
3 times, most recently
from
fcb0470
to
cd40ae8
Compare
conorbros
force-pushed
the
protocol-v5-refactor
branch
from
cd40ae8
to
b0c340c
Compare
rukai
reviewed
Mar 31, 2023
rukai
reviewed
Mar 31, 2023
rukai
reviewed
Mar 31, 2023
conorbros
force-pushed
the
protocol-v5-refactor
branch
from
f12c536
to
d09fd75
Compare
rukai
reviewed
Apr 2, 2023
rukai
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will supersede the previous v5 PR. This PR implements support for the Cassandra v5 protocol without support for compression or non-self contained frames, which will be completed in followups.