Replace openssl with rustls #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
rustls
branch
12 times, most recently
from
529d060
to
5b7c12f
Compare
rukai
force-pushed
the
rustls
branch
2 times, most recently
from
fc18505
to
f416b9e
Compare
conorbros
approved these changes
Apr 6, 2023
benbromhead
approved these changes
Apr 11, 2023
benbromhead
reviewed
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation does end up a bit more complicated than with openssl, but the replacement of a C dependency with a rust one is definitely a win for memory safety and ease of building.